#1449 ✓ resolved
Israel Tsadok

Sigint handling

Reported by Israel Tsadok | March 1st, 2012 @ 01:59 PM | in 1.3

Much like #1045 describes with regards to SIGTERM, the play python script does not specifically handle SIGINT. That means that in Linux, pressing Ctrl-C to stop the process simply sends SIGINT to both parent and child, and they shut down at their own time. When there's a lot of cleanup for the Java process (e.g. when ddl is create-drop), this can cause confusing situations where we get the prompt back, but Java is still running and the port is still taken.

Framework version: 1.2.4
Platform you're using: Linux

Reproduction steps:

~$ cd play/samples-and-tests/yabe
~/play/samples-and-tests/yabe$ cat << END > app/Shutdown.java
import play.*;
import play.jobs.*;
import play.test.*;
 
import models.*;
 
@OnApplicationStop
public class Shutdown extends Job {
 
    public void doJob() {
        try {
            Thread.sleep(5000);
        } catch (Exception e) {
        }
    }
 
}
END
~/play/samples-and-tests/yabe$ ../../play run --http.port=9002
~        _            _ 
~  _ __ | | __ _ _  _| |
~ | '_ \| |/ _' | || |_|
~ |  __/|_|\____|\__ (_)
~ |_|            |__/   
~
<snip>
15:50:16,906 INFO  ~ Application 'Yet Another Blog Engine' is now started !
^C~ ...
~/play/samples-and-tests/yabe$ ps
  PID TTY          TIME CMD
 3781 pts/6    00:00:00 bash
16635 pts/6    00:00:09 java
16665 pts/6    00:00:00 ps
~/play/samples-and-tests/yabe$ ps
  PID TTY          TIME CMD
 3781 pts/6    00:00:00 bash
16635 pts/6    00:00:09 java
16666 pts/6    00:00:00 ps
~/play/samples-and-tests/yabe$ ps
  PID TTY          TIME CMD
 3781 pts/6    00:00:00 bash
16668 pts/6    00:00:00 ps

Fix: I added a handler for sigint that sends SIGTERM to the process on the first Ctrl-C, and SIGKILL on the second Ctrl-C. This way you can forcefully stop a play process that doesn't shut down in time.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Play framework

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the http://www.playframework.org website.

Source code is hosted on github

Check out our repository at http://github.com/playframework/play

Contributing, creating a patch

Please read the contributor guide

Reporting Security Vulnerabilities

Since all bug reports are public, please report any security vulnerability directly to guillaume dot bort at gmail dot com.

Creating a bug report

Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Shared Ticket Bins

Pages