#775 ✓ resolved
Havoc Pennington

Session cookie gets lost in FunctionalTest

Reported by Havoc Pennington | April 25th, 2011 @ 06:13 PM | in 1.2.2

In Play 1.2, the session cookie isn't used across multiple requests (in the same test).

There are two causes I think.

  1. if session maxAge is NOT set in the config, the problem is that FunctionalTest.java incorrectly treats missing maxAge as maxAge=0 instead of as "keep for browser session"
  2. if session maxAge IS set in the config, the problem is that Scope.java does not add the timestamp to the session when it first creates the cookie (when there was no existing session cookie). this means the first time the cookie is set, the created cookie is invalid (no timestamp) and gets discarded.

I have the trivial patch for both issues, will put up on github momentarily and also attach here.

The second issue presumably breaks even outside of functional tests, but it's easy to imagine why nobody would notice in most applications since the first page load probably doesn't put anything important in the session.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Play framework

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the http://www.playframework.org website.

Source code is hosted on github

Check out our repository at http://github.com/playframework/play

Contributing, creating a patch

Please read the contributor guide

Reporting Security Vulnerabilities

Since all bug reports are public, please report any security vulnerability directly to guillaume dot bort at gmail dot com.

Creating a bug report

Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Shared Ticket Bins

People watching this ticket

Attachments

Referenced by

Pages