#920 ✓ resolved
Paulecci

Response Streaming - Chunked encoding BUG

Reported by Paulecci | June 19th, 2011 @ 03:18 PM | in 1.2.5 (closed)

Using the Response Streaming feature the method response.writeChunk() will add an extra pair of CRLF for each chunk. That means instead of closing each chunk with a CRLF (as requested by the specification) it adds the following bytes CRLFCRLF.

This corrupts the returned content because the browsers will not remove the extra CRLF pair.

Framework version: 1.2.1
Platform you're using: Mac OSX

Reproduction steps:

1) add the following method in your Application controller and map in the routes conf file:

public static void chunk(String echo) { 
      response.contentType = "text/csv";
      response.setHeader("Transfer-Encoding", "chunked");
      response.writeChunk("echo=");
      response.writeChunk(echo);
}

2) download the page at the following address http://localhost:9000/chunk.html?echo=Test

3) The expected content should the string "echo=Test" but in the downloaded response would be

echo=\r\n
Test\r\n

Details:

Inspecting the returned content bytes (using curl) it is possibile to see that Play returns the following content for the above request:

HTTP/1.1 200 OK
Server: Play! Framework;1.2.1;dev
Content-Type: text/csv; charset=utf-8
Transfer-Encoding: chunked
Cache-Control: no-cache
7
echo=

6
Test

0

The first chunk should be length 5 instead is 7, the second should be 4 instead is 6.

Looking to the byte stream you will find the content (as hex bytes stream, with below the ascii equivalent):

37 0D 0A 65 63 68 6F 3D 0D 0A 0D 0A 36 0D 0A 54 65 73 74 0D 0A 0D 0A 30 0D 0A 0D 0A
 7 CR LF  e  c  h  o  = CR LF CR LF  6 CR LF  T  e  s  t CR LF CR LF  0 CR LF CR LF

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Play framework

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the http://www.playframework.org website.

Source code is hosted on github

Check out our repository at http://github.com/playframework/play

Contributing, creating a patch

Please read the contributor guide

Reporting Security Vulnerabilities

Since all bug reports are public, please report any security vulnerability directly to guillaume dot bort at gmail dot com.

Creating a bug report

Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Shared Ticket Bins

Attachments

Referenced by

Pages