#398 ✓ resolved
ronin-124355 (at lighthouseapp)

ExecutableTemplate.template should be made public

Reported by ronin-124355 (at lighthouseapp) | November 10th, 2010 @ 02:13 PM | in 1.1.1

when creating a custom tag based on a fast tag, it is not possible to raise a TemplateExecutionException because its constructor accept a parameter ExecutableTemplate.template which is not visible.

Solution:
1. make the variable ExecutableTemplate.template public
2. create a public accessor in ExecutableTemplate
3. add a TemplateExecutionException constructor which accepts a ExecutableTemplate as parameter

I believe the most elegant version is #3

Framework version: 1.1
Details:

Consider the code below, it won't compile because template.template is not visible

package com.crionics.tags
public class TestTag extends FastTags {

public static void _test(Map<?, ?> args, Closure body, PrintWriter

out, ExecutableTemplate template, int fromLine) {

    String publickey = (String) args.get("publicKey");
    String privatekey = (String) args.get("privateKey"); 
    if (publickey == null || privatekey == null) 
        throw new TemplateExecutionException(template.template, fromLine, ERROR_MSG, new TagInternalException(ERROR_MSG));

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Play framework

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the http://www.playframework.org website.

Source code is hosted on github

Check out our repository at http://github.com/playframework/play

Contributing, creating a patch

Please read the contributor guide

Reporting Security Vulnerabilities

Since all bug reports are public, please report any security vulnerability directly to guillaume dot bort at gmail dot com.

Creating a bug report

Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Shared Ticket Bins

People watching this ticket

Referenced by

Pages