#963 ✓ resolved
Paul Wong

Setting play.id during runtime

Reported by Paul Wong | July 6th, 2011 @ 05:32 AM | in 1.2.5 (closed)

In our enterprise environment, we have a single build version, which progresses through multiple environments (ie DEV -> SIT -> PROD).
Issue is that 'play.id' needs to be updated for every environment, therefore needs to be built for specific environment. We need a single build to work for all environments where 'play.id' is different.

Framework version: 1.2+
Platform you're using: Windows, Linux

Reproduction steps:

Details:
We can potentially make the behavior for retrieval of 'play.id' be overridden by introducing a method like getPlayId(). Default implementation would be to get it via getServletContext().getInitParameter("play.id");
Other people will be able to override this behavior to anything they want.
Simple change is done as attached.

Comments and changes to this ticket

  • Paul Wong

    Paul Wong August 12th, 2011 @ 01:15 AM

    This may not be needed any more, given that there is the @include. feature in application.conf.

    What would be nice is to have more documentation on the @include. feature in application.conf and highlight how properties can be overriden based on system properties. For example we can add this line in application.conf
    @include.database=extended-properties-${systemProperty}.conf

    And we can have multiple versions of extended-properties-??.conf in our project. So to configure which database values are used, we can set the 'systemProperty' when we start Play! by passing JVM parameter:
    -DsystemProperty=SIT

    This way, we can reserve play.id to only DEV and PROD. Intention of being in 'System Integration Testing' environment, Play! should still run as play.id = PROD, but load up a different set of configurations.

  • Axel T

    Axel T January 3rd, 2012 @ 01:43 PM

    I'm running into the same problem... Have you found some good workaround to control the play.id in a war?

    Why not just change the line in servletwrapper.java from

        final String playId = e.getServletContext().getInitParameter("play.id");
    

    to

        final String playId = System.getProperty("play.id",e.getServletContext().getInitParameter("play.id"));
    

    Cheers,
    Axel

  • Neoh59

    Neoh59 February 8th, 2012 @ 04:59 PM

    +1 : it could be a nice feature

    See here : https://groups.google.com/d/topic/play-framework/9GNsDJQimMk/discus...

    For me it's a first step. And it would be useful to allow conf file (main application.conf file or @include conf files, to be outside the war packaging, with an absolute path defined by a system property)

  • Toomas Römer

    Toomas Römer April 16th, 2012 @ 08:26 AM

    +1

    We package our archive and don't want to build different binaries for different settings!

  • Igor Bljahhin

    Igor Bljahhin April 16th, 2012 @ 08:28 AM

    +1 This should be very nice feature, because then we could just copy WAR to production server, without changing play.id in web.xml.

  • Nicolas Leroux

    Nicolas Leroux May 16th, 2012 @ 11:56 AM

    • State changed from “new” to “confirmed”
    • Assigned user set to “Nicolas Leroux”
    • Milestone set to 1.2.5
    • Milestone order changed from “668” to “0”
  • Play Duck
  • Nicolas Leroux

    Nicolas Leroux May 16th, 2012 @ 09:16 PM

    • State changed from “confirmed” to “resolved”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Play framework

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the http://www.playframework.org website.

Source code is hosted on github

Check out our repository at http://github.com/playframework/play

Contributing, creating a patch

Please read the contributor guide

Reporting Security Vulnerabilities

Since all bug reports are public, please report any security vulnerability directly to guillaume dot bort at gmail dot com.

Creating a bug report

Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Shared Ticket Bins

Attachments

Pages