#1092 new

two legged oauth not working using "null"

Reported by ps | September 1st, 2011 @ 12:11 PM

There is a regression in the oauth support.

In play 1.2.1 (and possibly 1.2.2) it was possible to do something like this for 2-legged oauth:

ServiceInfo si = new ServiceInfo(null, null, null, user, secret);
WS.HttpResponse response = WS.url(url).oauth(si, new TokenPair(null, null)).get();

In play 1.2.3 it is neccessary to write it like this:

ServiceInfo si = new ServiceInfo(null, null, null, user, secret);
WS.HttpResponse response = WS.url(url).oauth(si, "", "").get();

I guess this is because TokenPair handled nulls correctly, but the new oauth() method does not.
This took me some time to figure out.

Btw - its quite verbose to handle 2-legged oauth with all these unneeded parameters. Maybe you could introduce a shortcut method?

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

People watching this ticket

Referenced by