#1408 new
Mark Grand

DB does not check that the thread's current connection is

Reported by Mark Grand | February 1st, 2012 @ 12:11 AM

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem. WARNING: Do not fill bugs related describing security vulnerabilities. Email directly guillaume dot bort at gmail dot com for that.

Framework version: 1.2.2
Platform you're using:

Reproduction steps:

Details: DB.getConnection returns the database connection associated with the current thread without checking to see if it is not open or is no longer valid. At the very least, if there is an existing Connection object associated with the current thread, it should call the Connection objects's isClosed method and get a new connection if the existing one is closed.

Even though a Connection object is not closed, it may become invalid for such reasons as a time-out. Connection objects do have an isValid method for testing whether they are valid, however a call to isValid may be much more time consuming than a call to isClosed, because to determine the connection's validity, isValid may need to submit a query to the database. To be able to detect invalid connections without making all calls to getConnection much slower, I suggest adding the following new features to DB:

  • Add a getValidConnection method which always calls the isValue method of an existing connection and tries to get a new connection if the existing connection is not valid.

  • Since the most common reason for a connection to become invalid is for it to time-out due to being idle, add a method to DB called setConnectionValidationInterval(int). If this method is passed a positive value then the getConnection method will call isValid some of the time. The next call to getConnection will call the Connection object's isValid method. The time of that call to isValue gets remembered. After a number of seconds have elapsed that is equal to the value passed to setConnectionValidationInterval, the next call to getConnection will call isValid and a new time will be remembered. A more complicated but better-performing solution would be to put a wrapper around the connection that is returned by getConnection so that every database operation will cause DB to reset the time when a call to getConnection will result in a call to isValid.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

People watching this ticket