#414 ✓worksforme

Better error message when action method is missing parameter

Reported by Rico | November 14th, 2010 @ 06:43 PM

A feature request from the mailing list:


I ran into the following problem:
My controller class defined an action method like so:

public static void editPOST() {
   // method definition is missing the parameter 
   // really should be: public static void editPOST(Long id) {...} 

In the view, I tried to insert a form:
#{form @Website.editPOST(page.id)} ... This failed with a NullPointerException and no details:
Oops: NullPointerException
An unexpected error occured caused by exception NullPointerException:
play.exceptions.UnexpectedException: Unexpected Error

    at play.mvc.results.RenderTemplate.apply(RenderTemplate.java:30)
    at play.mvc.ActionInvoker.invoke(ActionInvoker.java:302) 
    at Invocation.HTTP Request(Play!)

Caused by: java.lang.NullPointerException

    at play.mvc.results.RenderTemplate.apply(RenderTemplate.java:27)
    ... 2 more

Usually the Play! error messages are very detailed. Maybe this case
could be added and an appropriate error message (e.g. "Missing
parameter 'id'") can be added.

Framework version: 1.1

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.