#1011 confirmed
Renato Oliveira

Binder ignores locale for decimal values.

Reported by Renato Oliveira | August 3rd, 2011 @ 01:41 PM | in 1.4.x

Framework version: 1.2.2
Platform you're using: Mac OS (dev), Cent OS 5 (prod)

Reproduction steps:
To reproduce this, you need to set application.lags=pt, or have the pt_BR language on your browser.

Details:
Brazilian pattern for a decimal value is #.#00,00, the decimal separator is ",".

When I use a form, I can format the value that I read on db from 1234.56 to the brazilian pattern 1.234,56.
The user will be happy to see the value in a friendly way.

When I the form is submitted, this pattern is ignored from the binder, and an "Incorrect Value" error message is placed.

This happens because the binder doesn't understand the format of the value, wich can be solved if it considers locale.

On Binder.java, it uses FLoat.parseFloat(), Double.parseDouble and new BigDecimal() to convert the string value to the proper type.

I suggest a change on it to use a DecimalFormat considering locale (Lang.getLocale()).

Something like this:
DecimalFormat.getInstance(Lang.getLocale()).parse(value).floatValue(); // float
DecimalFormat.getInstance(Lang.getLocale()).parse(value).doubleValue(); // double
(BigDecimal) DecimalFormat.getInstance(Lang.getLocale()).parse(value); // BigDecimal

Thanks.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Tags

Pages