#1050 new
Aaron White

Params not re-parsed on .get if previous thread contained same key

Reported by Aaron White | August 20th, 2011 @ 10:46 PM

Framework version: 1.2.2 + Scala 0.9.1

I have an @Before handler that is reading the "params" variable, and doing a .get on a common parameter key. When handling POST (for sure, maybe also GET), reading a param returns stale data from a previous thread.

From the looks of the Scope.java code, the public get(String key) code does NOT do a checkAndParse if the key is currently in the params object. Since this web-thread is recycled, if it is a common param, chances are high the params will not be parsed.

Let me know if I can provide more info

Comments and changes to this ticket

  • Aaron White

    Aaron White August 20th, 2011 @ 11:01 PM

    I may have my understanding about checkAndParse incorrect, but the bug description stands, my @Before handler is seeing stale data from a previous use of the thread when using the "params" variable

  • Aaron White

    Aaron White August 20th, 2011 @ 11:46 PM

    And if somehow stale thread data is already in the Params object, the mergeInValues will just add another value to an array, while get continues to return the first value. Real mind bender here :/

  • Aaron White

    Aaron White August 21st, 2011 @ 11:57 AM

    Ok, ultimately play was not at fault. I'm unclear why the get(String key) method doesn't also do a checkAndParse, but I'm satisfied that in my case at least, this was not the ultimate issue, please feel free to close as invalid

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

People watching this ticket

Pages