#1133 ✓resolved
Daniel Dekany

Javassist "unset variable" error when applying LocalvariablesNamesEnhancer

Reported by Daniel Dekany | September 26th, 2011 @ 10:25 PM | in 1.3 (closed)

This is yet another case of LocalvariablesNamesEnhancer crashes. I haven't found a bug report of this particular crash, "unset variable". So put this into a Controller:

    private static void localVarEhancerCrasher() {
        Object obj1;
        Object obj2 = "";
        try {
            if (Math.random() < 0.5) return;
            obj1 = "";
        } finally {

and when Play tries to compile it should crash with:

Oops: UnexpectedException
An unexpected error occured caused by exception UnexpectedException: While applying class play.classloading.enhancers.LocalvariablesNamesEnhancer on controllers.Admin

play.exceptions.UnexpectedException: While applying play.CorePlugin@6a969c29 on controllers.Admin
    at play.plugins.PluginCollection.enhance(PluginCollection.java:454)
    at play.classloading.ApplicationClasses$ApplicationClass.enhance(ApplicationClasses.java:208)
    at play.classloading.ApplicationClassloader.detectChanges(ApplicationClassloader.java:315)
    at play.Play.detectChanges(Play.java:595)
    at play.Invoker$Invocation.init(Invoker.java:186)
    at Invocation.HTTP Request(Play!)
Caused by: play.exceptions.UnexpectedException: While applying class play.classloading.enhancers.LocalvariablesNamesEnhancer on controllers.Admin
    at play.CorePlugin.enhance(CorePlugin.java:296)
    at play.plugins.PluginCollection.enhance(PluginCollection.java:451)
    ... 5 more
Caused by: javassist.CannotCompileException: by javassist.bytecode.BadBytecode: unset variable
    at javassist.CtBehavior.insertBefore(CtBehavior.java:683)
    at javassist.CtBehavior.insertBefore(CtBehavior.java:640)
    at play.classloading.enhancers.LocalvariablesNamesEnhancer.enhanceThisClass(LocalvariablesNamesEnhancer.java:296)
    at play.CorePlugin.enhance(CorePlugin.java:293)
    ... 6 more
Caused by: javassist.bytecode.BadBytecode: unset variable
    at javassist.bytecode.stackmap.TypeData.setType(TypeData.java:44)
    at javassist.bytecode.stackmap.Tracer.checkParamTypes(Tracer.java:908)
    at javassist.bytecode.stackmap.Tracer.checkParamTypes(Tracer.java:898)
    at javassist.bytecode.stackmap.Tracer.doInvokeMethod(Tracer.java:813)
    at javassist.bytecode.stackmap.Tracer.doOpcode148_201(Tracer.java:617)
    at javassist.bytecode.stackmap.Tracer.doOpcode(Tracer.java:101)
    at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:161)
    at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171)
    at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:171)
    at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:120)
    at javassist.bytecode.stackmap.MapMaker.make(MapMaker.java:96)
    at javassist.bytecode.MethodInfo.rebuildStackMap(MethodInfo.java:404)
    at javassist.bytecode.MethodInfo.rebuildStackMapIf6(MethodInfo.java:389)
    at javassist.CtBehavior.insertBefore(CtBehavior.java:674)
    ... 9 more

Play 1.2.3, Java 1.6.0_26-b03 32 bit and 1.6.0_24-b07 64 bit, Win7 64.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Referenced by