#1384 confirmed
Morten Kjetland

Server fails without error when rejecting invalid proxied requests

Reported by Morten Kjetland | January 19th, 2012 @ 09:51 AM | in 1.4.x

Framework version: 1.2.4
Platform you're using: Windows

When play is configured to obey XForwardedSupport and is receiving request with invalid ip, the following error / log-message is not logged due to a NPE:

Oops: RuntimeException
An unexpected error occured caused by exception RuntimeException: This proxy request is not authorized: 127.0.0.1

play.exceptions.UnexpectedException: Unexpected Error
    at play.server.PlayHandler.serve500(PlayHandler.java:752)
    at Invocation.Message Received(Play!)
Caused by: java.lang.RuntimeException: This proxy request is not authorized: 127.0.0.1
    at play.mvc.Http$Request.parseXForwarded(Http.java:379)
    at play.mvc.Http$Request.createRequest(Http.java:366)
    at play.server.PlayHandler.parseRequest(PlayHandler.java:599)
    ... 1 more

This makes it really hard to debug proxy stuff

The code below fixes it:


// class: PlayHandler
// method: public static void serve500(Exception e, ChannelHandlerContext ctx, HttpRequest nettyRequest)


        Request request = Request.current();
        // NEW CODE
        if ( request == null ) {
            // we failed before the request object was initialized-'
            // Lets create a dummy one so that our errorhandling works
            request = new Request();
            request.format = "txt";
            request.method = "[info missing]";
            request.url = "[info missing]";
        }
        // NEW CODE END

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Pages