#1401 new
Alexander Reelsen

Using validation and await in one action always results in broken validation

Reported by Alexander Reelsen | January 29th, 2012 @ 02:27 PM

Whenever you use annotation based validation in an action and await() to wait for some response, the validation happens twice and the second time it happens does not happen with the original parameter which leads to an always broken validation. Please check the source code example for some explanation :-)

Framework version: 1.2.4
Platform you're using: macosx

Reproduction steps:

Create the following action

public static void index(@URL String str) {

if (validation.hasErrors()) {
    renderText("Validation errors " + validation.errorsMap() + " with field " + str + "\n");
}

await(new DelayJob().now());

String output = String.format("Length for %s, but validation is filled: %s", str, validation.errorsMap());
renderText(output);

}

Call it via curl and see it fail

curl localhost:9000?str=http://www.test.de

Length for http://www.test.de, but validation is filled: {str=[Not a valid URL]}

Details:

When you debug into the URLCheck, you will see that the value is "http://www.test.de" before the await() is hit, but in the second run it is "http://www.test.de, http://www.test.de" - which of course will lead to a failing validation and thus put the error message in the context.

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

People watching this ticket

Pages