#1475 new
Mathieu Petitdant

Secure module onDisconnect hook breaks logout

Reported by Mathieu Petitdant | March 30th, 2012 @ 02:17 PM

Framework version: 1.2.4
Platform you're using: Windows 7

Reproduction steps:
On my Security class, whatever I put in the ondisconnect method I break the logout sequence. On the invoke("onDisconnect") an InvocationTargetException is raised even if my code looks like :

 public static void onDisconnect() {
        int i = 1 + 1;
    }

To bypass the bug, I do my custom action in Application.logout, then I manually call Secure.logout().

Details:

Comments and changes to this ticket

  • Fabio Falci

    Fabio Falci March 30th, 2012 @ 10:29 PM

    onDisconnect is a method of Secure.Security:

    **
     * This method is called after a successful sign off.
     * You need to override this method if you wish to perform specific actions (eg. Record the time the user signed off)
     */
    static void onDisconnected() {
    }
    

    It is not an action, so it cannot be a 'public static' method.
    Try this:

     static void onDisconnect() {
            int i = 1 + 1;
     }
    
  • Mathieu Petitdant

    Mathieu Petitdant April 2nd, 2012 @ 08:01 AM

    My bad, sorry about that. It's working without 'public' modifier.
    I don't see how to close the ticket ?

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Pages