#1553 new
Tomas Kulich

FunctionalTest.GET with redirect crashes

Reported by Tomas Kulich | June 20th, 2012 @ 01:16 PM

Framework version: 1.2.4
Platform you're using: not important

FunctionalTest.GET(Object url, boolean followRedirect) crashes when followRedirect==true and redirect really occurs. It ends up with

java.lang.RuntimeException: java.net.MalformedURLException: no protocol: /auth/login
    at play.test.FunctionalTest.GET(FunctionalTest.java:74)

problem is caused by line 72 from FunctionalTest.java:

redirectedUrl = new java.net.URL(redirectedTo.value());

redirectedTo.value() can be relative adress (/auth/login in my case) which is not a valid java.net.URL.
Problem can be fixed easily by removing this cast which is not important after all. My version of GET which I use for internal purposes:

     * Allways redirects if possible.
    public static Response myGET(String url) {
        int maxNumberOfRedirects=100;
        Response response = GET(url);
        for (int i = 0; i < maxNumberOfRedirects; i++) {
            if (Http.StatusCode.FOUND == response.status) {
                Http.Header redirectedTo = response.headers.get("Location");
                response = GET(redirectedTo.value());
            } else {    
            throw new RuntimeException("Maximum number of redirects exceeded while doing for request.. Infinite loop?");
        return response;

Moreover, if there is an infinite redirect loop, original version of GET seems to ignore this and produce StackOverflow. This is also not cool.

Finally, it would be nice, if POST had also redirect argument (in this case, it should follow redirects with GET). Note that it is very hard to do proper unit testing in Play 1.x, so at least proper enviroment for quick & readable application/functional testing would be nice.

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.