#1599 ✓duplicate
Hong Yew

Aggressive C3P0 connection monitoring causes performance issue

Reported by Hong Yew | September 13th, 2012 @ 10:57 AM

I am filling a bug which I have offered a patch to fix.

Framework version: 1.2.5
Platform you're using: Windows

Reproduction steps:
1. Setup Play application to use Oracle JDBC
2. Run the application
3. Setup trace in Oracle side or network monitoring using Wireshark or similar

You will find the application sends a query to Database every few seconds, depending on the number of connections in the pool. The query is similar to one in this article: http://stackoverflow.com/questions/2630613/how-to-avoid-this-very-h...

Details:
Play's C3P0 sends aggressive database heartbeat to database which results in substantial load to the database with the query showed in the above stackoverflow post.

Play issues the query every 10 seconds for every connection. This 10 seconds is hard-coded by Play in DBPlugin. The high frequency coupled with an inefficient getMetaData() query implemented by Oracle JDBC driver is a serious performance issue.

Attached is the fix/patch in DBPlugin to make this configurable. See line 131 to 136.

To configure the settings, add c3p0.properties to /conf with:

c3p0.idleConnectionTestPeriod=XXXX (eg. in seconds)

For Oracle, the set the test query to something lightweight

c3p0.preferredTestQuery=select 1 from dual

Alternatively the settings could be incorporate into application.conf (Play.configuration.getProperty("c3p0.idleConnectionTestPeriod", 10) and default to 10 to maintain backward compatibility and offer the option to change.

Happy to contribute if you need assistance.

Hong

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Attachments

Referenced by

Pages