#1764 confirmed
ggd543 (at gmail)

URL Regex is not correct

Reported by ggd543 (at gmail) | December 7th, 2013 @ 05:36 AM | in 1.4.x

Framework version: Play 1.2.x
Platform you're using: Windows 7

Details:

The following url is considered as invalid format based on the url regex:

http://localhost/
http://localhost:80/
http://127.0.0.1
http://127.0.0.1:80

Class: play.data.validation.URLCheck

Comments and changes to this ticket

  • notalifeform (at gmail)

    notalifeform (at gmail) December 9th, 2013 @ 09:06 PM

    • State changed from “new” to “confirmed”
    • Assigned user changed from “Guillaume Bort” to “notalifeform (at gmail)”
    • Milestone set to 1.3
  • ggd543 (at gmail)

    ggd543 (at gmail) December 10th, 2013 @ 01:28 AM

    I have make a bugfix pull request on github , Pleas check

  • Alex

    Alex December 19th, 2013 @ 01:36 AM

    • Tag changed from bug, regex to bug, regex, validation

    One question about URL validation:
    Firefox, chrome allow to use some special character (not urlencode) like '{', '}', should these characters be allowed?

    http://www.bestbuy.com/site/amazon-kindle-fire-hd-7-inch-tablet-with-8gb-memory-2nd-generation-black/2216082.p?id=1219070629225&skuId=2216082&ref=06&loc=01&ci_src=14110944&ci_sku=2216082&extensionType={adtype}:{network}&s_kwcid=PTC!pla!{keyword}!{matchtype}!{adwords_producttargetid}!{network}!{ifmobile:M}!{creative}&kpid=2216082&k_clickid=046dfb11-a86b-b669-52e3-00004228f299
    

    or maybe add an option in the tag to allow / disallow these characters?
    @notalifeform what do you think about it?

  • Alex

    Alex January 7th, 2015 @ 01:44 AM

    • Milestone changed from 1.3 to 1.4.x
  • Robert Rettig

    Robert Rettig May 29th, 2017 @ 10:20 PM

    those urls should not be validated by default only with special flags to allow them
    this gist is very advanced and reasoable https://gist.github.com/dperini/729294

    updated pull request: https://github.com/playframework/play1/pull/1157

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Pages