#1876 new
ryenus

local jar artifacts should not be extracted to modules dir

Reported by ryenus | September 24th, 2014 @ 04:16 AM | in 1.4.x

local included .jar artifacts got extracted to modules/ directory,
meanwhile expected to simply copied to lib/ directory.

Framework version:
1.2.7

Platform you're using:
java 1.6/1.7/1.8 x64, Windows 8 x64

Here is a test module
https://github.com/ryenus/play1-test-mod-1876

Reproduction steps:
0. remove or rename ${user.home}/.ivy2/cache to ${user.home}/.ivy2/cache-renamed (or whatever)
1. go to play installation dir, then framework/modules directory, and clone the test module https://github.com/ryenus/play1-test-mod-1876
1.1 alternatively, create a new play module, e.g. play1-test-mod, in dir framework/modules of the play installation
1.1.1. put some-artifact-1.0.jar file in play1-test-mod/ext
1.1.2. add ext/some-artifact-1.0.jar to conf/dependencies.yml
2. run play deps --sync,
3. actual result: some-artifact-1.0.jar got extracted to modules/ dir

Details:
This can be easily fixed by ensure '.jar' files are not
treated as modules in play.deps.DependenciesManage#isPlayModule()
see https://github.com/playframework/play1/pull/803

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Attachments

Pages