#1947 ✓resolved
John

Job::withinFilter Only Calls First PlayPlugin Filter It Finds. (Invoker Calls All Filters)

Reported by John | May 20th, 2015 @ 04:26 PM | in 1.4.2 (closed)

Framework version: 1.3.1
Platform you're using: Windows 7 x64, Oracle JDK 1.8.0u40 x64

Reproduction steps:

Create two PlayPlugin implementers that define a filter. Configure both in play.plugins.
When executed from a Job, only the highest priority filter will run. When executed by Invoker, both will run. (Although Invoker seems to execute the Invocation for each plugin rather than chaining?)

Details:

play.jobs.Job::withinFilter stops iterating after first plugin filter is found. play.Invoker.Invocation::withinFilter does not. It seems like this behavior should be consistent.

https://github.com/playframework/play1/blob/1.3.1/framework/src/pla...

private V withinFilter(play.libs.F.Function0<V> fct) throws Throwable {
    for (PlayPlugin plugin :  Play.pluginCollection.getEnabledPlugins() ){
       if (plugin.getFilter() != null) {
          return (V)plugin.getFilter().withinFilter(fct);
       }
    }
    return null;
}

https://github.com/playframework/play1/blob/1.3.1/framework/src/pla...

 private void withinFilter(play.libs.F.Function0<Void> fct) throws Throwable {
      for( PlayPlugin plugin :  Play.pluginCollection.getEnabledPlugins() ) {
           if (plugin.getFilter() != null)
            plugin.getFilter().withinFilter(fct);
       }
    }

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Tags

Referenced by

Pages