#1962 ✓resolved
Andrei Solntsev

Getting Static Initialization Deadlock in class DataParser

Reported by Andrei Solntsev | June 30th, 2015 @ 12:12 PM | in 1.3.2 (closed)

Sometimes we get Static Initialization Deadlock after starting server.
The problem is in DataBinder class that
1) has static initialization block (which is synchronized on JVM level), and
2) references all its subclasses (that is bad practice in OOP)

The problem happens, when 2 different threads use DataBinder and one of its subclasses (UrlEncodedParser) at the same moment. Then UrlEncodedParser waits until DataParser class is initialized, but DataParser waits until UrlEncodedParser class is initialized. We get deadlock.

Framework version: 1.3.x
Platform you're using: Java 8, Linux

Reproduction steps: start play server

Details: many threaded stay in "Runnable" status for a long time. But actually they do not work, but waiting for something:

"play-thread-30" #192 prio=5 os_prio=0 tid=0x00007ffa20001800 nid=0x26a9 in Object.wait() [0x00007ff9a44c8000]
   java.lang.Thread.State: RUNNABLE
    at play.mvc.ActionInvoker.invoke(ActionInvoker.java:116)
"play-thread-1" #163 prio=5 os_prio=0 tid=0x00007ffa78008800 nid=0x2682 in Object.wait() [0x00007ff9a63e5000]
   java.lang.Thread.State: RUNNABLE
    at play.data.parsing.DataParser.<clinit>(DataParser.java:18)
    at play.mvc.Scope$Params.checkAndParse(Scope.java:365)
    at play.mvc.Scope$Params.all(Scope.java:463)
    at play.modules.logger.RequestLogPlugin.extractParams(RequestLogPlugin.java:103)

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Tags

Pages