#1978 new
R.Rettig

Multidb support enforces JPA initialization

Reported by R.Rettig | August 28th, 2015 @ 08:36 PM

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem. WARNING: Do not fill bugs related describing security vulnerabilities. Email directly guillaume dot bort at gmail dot com for that.

Framework version: 1.3.x ( commit cb97ad7f6e7527c392272bb3ac16e1ca5d087938 )
Platform you're using: all supported platforms

Reproduction steps: create a play app with db configuration but no jpa models

Details:
The inital merge for Multidb introduced the constraint, that JPA must be initialized.
https://github.com/playframework/play1/commit/cb97ad7f6e7527c392272...

The left out part of previous implementation is the return if no Entity annotated classes are found
https://github.com/playframework/play1/commit/cb97ad7f6e7527c392272...

the for loop should track the addition of classes to the hibernate config and after it it should call continue if no class was added.
https://github.com/playframework/play1/commit/cb97ad7f6e7527c392272...

please note that later commits have some additional advanced entity support features which should be tracked too.

there will be some play applications which do not want to have jpa but db support.

perhaps you know j2ee db config (documented in all sample application.conf)

# If you want to reuse an existing Datasource from your application server, use:
db=java:/comp/env/jdbc/myDatasource

if you choose such configuration you get a bad crash on getDefaultDialect

            properties.put("hibernate.dialect", getDefaultDialect(dbConfig, dbConfig.getProperty("db.driver")));

because such dialect will not exist if you are only interested in the datasource. but now you have no choice how to disable hibernate it is enforced!

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Pages