#2028 new
Sébastien Cesbron

Allow WS.getString to be called more than once

Reported by Sébastien Cesbron | February 22nd, 2016 @ 09:56 AM

With play 1.2.x WS.getString method can be used multiple times for each WS call. With play 1.4.x this is not possible due to http-async-client not allowing to call getResponseBodyAsStream multiple times

I've made a pull request https://github.com/playframework/play1/pull/956 that modify the getString method so it does not use getResponseBodyAsStream but getResponseBody. With this modification getString method can be used multiple times without trouble.

I also add a comment on getStream and getXml methods to indicates that theses methods can only be called once.

With this modification the behaviour of play 1.4.x is closer to the behaviour of play 1.2.x so it leads to less trouble for users who migrate from one version to the other.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.