#2036 ✓resolved
Alex

Force secure reverse routes config

Reported by Alex | February 25th, 2016 @ 04:57 AM | in 1.4.2 (closed)

Framework version: 1.4.x

Details:

For SSL-enabled application that have early SSL-termination (meaning the application code sees it as a non-https request but with the X-Forwarded-Proto header set), using reverse routing out of the box can be somewhat of a pain, since it blindly uses the host request header (which is non-https) for the redirect url. This results in multiple redirects for applications that already have custom code to redirect non-secure requests in a @Before filter (as mine does). As a result, flash parameters are dropped due to the multiple redirection.

This PR adds a configuration setting that will force the Router's reverse method to use a secure url (https://) for the actionDefinition's host.

This new configuration is of course opt-in, disabled by default. For what it's worth, I'm currently using this in a production app of mine on Heroku by pointing a custom buildpack to this build and it works like a charm! :smile:

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Pages