#2079 ✓resolved
Robert Rettig

dependencies install on windows fails if yml defines source and target the same

Reported by Robert Rettig | January 20th, 2017 @ 09:07 PM | in 1.5.0 (closed)

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem. WARNING: Do not fill bugs related describing security vulnerabilities. Email directly guillaume dot bort at gmail dot com for that.

Framework version: 1.4.x (1.4.0,1.4.1,1.4.3,1.4.4)
Platform you're using:
JAVA_VERSION="1.8.0_121" OS_NAME="Windows" OS_VERSION="5.2" OS_ARCH="amd64"

Reproduction steps:

  • use Windows !!!
  • create an app and copy the sqljdbc42.jar into the lib folder
  • setup local dependencies.yml like the following
    - play
    - local -> sqljdbc42 0
    - JDBC Driver:
        type:       local
        artifact:   "${application.path}/lib/[artifact].jar"
            - local -> sqljdbc42
  • run play deps

the intention of this configuration is to have some local jars already in the lib folder/repository (no external download required)

Details: on windows play deps will crash

Exception in thread "main" java.lang.RuntimeException: java.io.IOException: Source 'c:\dev\src\frameworks\play1\rica\lib\sqljdbc42.jar' and destination 'C:\dev\src\frameworks\play1\rica\lib\sqljdbc42.jar' are the same
        at play.libs.Files.copy(Files.java:41)
        at play.deps.DependenciesManager.install(DependenciesManager.java:259)
        at play.deps.DependenciesManager.retrieve(DependenciesManager.java:233)
        at play.deps.DependenciesManager.main(DependenciesManager.java:42)
Caused by: java.io.IOException: Source 'c:\dev\src\frameworks\play1\rica\lib\sqljdbc42.jar' and destination 'C:\dev\src\frameworks\play1\rica\lib\sqljdbc42.jar' are the same
        at org.apache.commons.io.FileUtils.copyFile(FileUtils.java:1077)
        at org.apache.commons.io.FileUtils.copyFile(FileUtils.java:1040)
        at play.libs.Files.copy(Files.java:39)
        ... 3 more

for some reason the absolutePath equals-check in play.libs.Files.copy does not work as expected under windwows. the expected behaviour would be to ignore it silent (not copying at all == keep the existing jar).

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.