#2121 ✓resolved
David Costanzo

JPABase.equals() invokes _key() before checking null/ref equality

Reported by David Costanzo | May 16th, 2017 @ 04:30 PM | in 1.5.0 (closed)

When profiling my application, I noticed an unexpected bottleneck in JPABase.equals(). In my use case, the "this" object and the "other" object arguments are usually references to the same object. However JPABase.equals() calls the relatively expensive _key() method before doing the very fast reference checks, even though it doesn't use the key until after the reference checks.

Per the "Contributor Guide" I am opening a Lighthouse ticket before submitting pull request.

Framework version: 1.4.3
Platform you're using: GNU/Linux

Reproduction steps:
By inspection

Details:
In my application's use case, I invoke JPABase.equals() many times with and in most cases the objects are the same reference (it's in a mutator method where, if the field doesn't change, then it's a no-op, otherwise it does an expensive update). Usually equals() operators are written to make this fast. However JPABase.equals() calls _key() before doing any reference checks and _key() uses reflection, which is relatively expensive.

From framework/src/play/db/jpa/JPABase.java

    @Override
    public boolean equals(Object other) {
        final Object key = this._key(); // <--- expensive calculated here

        if (other == null) {
            return false;
        }
        if (this == other) { // fast reference equality (common case)
            return true;
        }
        if (key == null) { // <-- not used until here
            return false;
        }

JPABase.equals() is functionally correct as-is, but I don't see any reason to call _key() before its return value is needed. Moving the call to _key() below the reference checks will make reference equality fast without slowing down the other cases. This is a non-invasive change that doesn't hurt any use cases and will help some.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Pages