#2140 ✓resolved
David Costanzo

Chunked responses are not testable by FunctionalTest

Reported by David Costanzo | November 16th, 2017 @ 08:27 PM | in 1.5.1

A controller action which writes its response in chunks is not testable by FunctionalTest.

I think the problem is that FunctionalTest does not register any onWriteChunk handlers on the Response object which it provides to the controller action, so when the controller action calls Response.writeChunk() it throws an UnsupportedOperationException in play.mvc.Http.Response.writeChunk(Object o)

public void writeChunk(Object o) {
    this.chunked = true;
    if (writeChunkHandlers.isEmpty()) { // <--- no onWriteChunk handlers have been registered
        throw new UnsupportedOperationException("Your HTTP server doesn't yet support chunked response stream");
    }
    for (F.Action<Object> handler : writeChunkHandlers) {
        handler.invoke(o);
    }
}

I have reproduced this on play-1.4.4 (the version I'm using) and the latest code in GitHub.

Steps to Reproduce

1) Run play new to create a new application

2) Change Application.java to this

package controllers;

import play.mvc.Controller;

public class Application extends Controller {

    public static void index() {
        response.setContentTypeIfNotSet("text/html; charset=" + play.Play.defaultWebEncoding);
        response.writeChunk("Hello, World!");
    }
}

3) Change ApplicationTest.java to

import org.junit.Test;

import play.mvc.Http.Response;
import play.test.FunctionalTest;

public class ApplicationTest extends FunctionalTest {

    @Test
    public void testThatIndexPageWorks() {
        Response response = GET("/");
        assertIsOk(response);
        assertContentType("text/html", response);
        assertCharset(play.Play.defaultWebEncoding, response);
        assertContentEquals("Hello, World!", response); // <-- this is added
    }
}

4) Run play auto-test

What Happens:
ApplicationTest.testThatIndexPageWorks reports Failure, expected:<[Hello, World]> but was:<[]>.

Expected Result:
All tests pass.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Pages