#2144 new
Oleksandr Lykhonosov

play.mvc.Http.Request.isModified and play.server.PlayHandler.isModified - Incorrect usage of Logger.error and Logger.warn

Reported by Oleksandr Lykhonosov | January 15th, 2018 @ 10:43 PM

play.mvc.Http.Request.isModified(String etag, long last):

...
try {
   Date browserDate = Utils.getHttpDateFormatter().parse(headers.get("if-modified-since").value());
   if (browserDate.getTime() >= last) {
       return false;
   }
} catch (ParseException ex) {
    Logger.error("Can't parse date", ex); // <== Here
}
...

play.serverPlayHandler.isModified(String etag, long last, HttpRequest nettyRequest):

...
try {
    Date browserDate = Utils.getHttpDateFormatter().parse(ifModifiedSince);
    if (browserDate.getTime() >= last) {
        return false;
    }
} catch (ParseException ex) {
    Logger.warn("Can't parse HTTP date", ex); // <== Here
}
...

We will not see the real cause of the error of exception in logs - the Throwable argument is just ignoring

As far as I can see, the reason (Throwable) should be the first argument of Logger.error(...) and Logger.warn(...):

class play.Logger

 warn(Throwable e, String message, Object... args)
 error(Throwable e, String message, Object... args)

Framework version: 1.5.x
Platform you're using: Linux

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Pages