#2171 new
santos

Action context access from error templates for routes-defined 404 actions

Reported by santos | April 30th, 2018 @ 07:50 AM

FRAMEWORK VERSION

1.5.0

PLATFORM

Ubuntu 16.04.4 LTS, Java 1.8.0_171-b11

DESCRIPTION

This issue is similar to #2170, but for the cases where 404 actions are declared in the routes file. For these cases, action context items (e.g. controllers.Security.isConnected()) are not available to error templates and exceptions are thrown when they try to access them, resulting in HTTP 500 responses instead of HTTP 404 ones.

REPRODUCTION STEPS

  1. Create a brand new Play! 1.5.0 app (or reuse an existing one) and include the following code in app/views/errors/404.html:
<p>isConnected: ${controllers.Security.isConnected()}</p>
<p>Connected: ${controllers.Security.connected()}</p>
  1. In the routes file, add a route for a URL (1) and the 404 action. Example:
*       /notfound                        404
  1. Start the app

  2. Open a browser at http://localhost:9000/notfound

  3. Instead of HTTP 404, HTTP 500 is returned due to a NPE, as shown in logs:

Error during the 500 response generation

Execution exception (In {module:secure}/app/controllers/Secure.java around line 167)
NullPointerException occurred : null

play.exceptions.JavaExecutionException
    at play.templates.BaseTemplate.throwException(BaseTemplate.java:87)
    at play.templates.GroovyTemplate.internalRender(GroovyTemplate.java:307)
    at play.templates.GroovyTemplate.internalRender(GroovyTemplate.java:317)
    at play.templates.Template.render(Template.java:28)
    at play.templates.GroovyTemplate.render(GroovyTemplate.java:230)
    at play.server.PlayHandler.serve500(PlayHandler.java:788)
    at Invocation.HTTP Request(Play!)
Caused by: java.lang.NullPointerException
    at controllers.Secure$Security.isConnected(Secure.java:167)
    at /app/views/error.html.(line:12)
    at play.templates.GroovyTemplate.internalRender(GroovyTemplate.java:282)
    ... 5 more

TECHNICAL DETAILS

In class PlayHandler, the action context is reset in the init method, making it unavailable in templates.

No comments found

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Pages