#276 ✓resolved
Dirk

Reverse routing Date objects uses wrong format

Reported by Dirk | October 12th, 2010 @ 01:15 AM | in 1.1

If I pass a date parameter as part of a reverse route, the url that is
constructed will not output the date using the format I set
date.format in application.conf:

application.conf:
date.format=yyyy-MM-dd'T'HH:mm:ssz

action:
public static void feed(Date date) { ... }

routes:
/pets/{date}/feed Pets.feed

template:
@{Pets.feed(date)}

url:
/pets/2010-10-11 10:55:05.0/feed

The reason seems to be that somewhere along the line the Date is
converted into a java.sql.Timestamp. When the reverse router turns
this into a String it uses the toString() method, instead of using the
DateBinder:
http://github.com/playframework/play/blob/master/framework/src/play...

If I go to the generated url, play attempts to convert the String to a
Date using DateBinder, and fails, giving me null.

Apart from this bug, I have a question: Why does Play use the
configured date.format value for urls? Maybe it would be better to
just convert all Date and Timestamp variants into their milli-seconds
since the epoch equivalents?

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Referenced by

Pages