#505 confirmed
Laurent Ho

Url validation (URLCheck class) gives "Not a valid URL" for some valid urls

Reported by Laurent Ho | December 20th, 2010 @ 01:39 PM


public void testUrl() throws Exception {
    String baseUrl ="";
    Pattern urlPattern = Pattern.compile("^(http|https|ftp)\\://[a-zA-Z0-9\\-\\.]+\\.[a-zA-Z]{2,3}(:[a-zA-Z0-9]*)?/?([a-zA-Z0-9\\-\\._\\?\\,\\'/\\\\\\+&%\\$#\\=~])*$");

    boolean playValidate= urlPattern.matcher(baseUrl).matches() ;
    System.out.println("validator from Play (copy&pasted from URLCheck):"

    boolean isMatching = baseUrl

    System.out.println("validator from other project com.zenika.zenbinding.client.validator (found using google codesearching URLvalidator):"

    //Use apache commons?!

    //proposed solution, using JDK only
    boolean urlValidate = true;
    try {
        URL url = new URL(baseUrl);
    } catch (MalformedURLException e) {
        urlValidate = false;


Framework version: v1.1

Reproduction steps:
See the test case, containing an URL with digits only IP, which is not validated correctly.

The custom regex pattern in play's play.data.validation.URLCheck class seems not to tested enough.

Proposed fix:
OK there's no code for explicitly validating an URL/URI in the JDK, why not create an java.net.URL and mark it as invalid if the constructor throws a MalformedURLException?

*Alternatives: Apache commons comes to mind of course, and it got such a method, but in not so common component, and which has unwanted dependency on 'oro' artifact, see:

Or other pattern, see in test case..

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.