#656 ✓wontfix

Proposed enhancement for the python war command to be able to configure a resource-ref

Reported by nicmarti | March 15th, 2011 @ 09:56 AM | in 1.3 (closed)

I'd like to propose an enhancement for Play 1.2 war command.

The usecase:
Play 1.2 lets you create a datasource in your application.conf as show below :
db=java:comp/env/jdbc/myapp db.resourceRef=jdbc/myapp

I tested with Tomcat 6, I created a Resource in context.xml and it works. There's no need to update the default web.xml.
However with IBM Websphere 7 it's a different story. You have to create a resource-ref in your web.xml. This is useful for sysadmin, they can bind this resource-ref with a technical datasource on WAS admin console.

So I updated framework\pym\play\utils.py and resources\war\web.xml

1) In the web.xml I added a new default resource-ref bloc
2) In my application.conf I added a new property that when defined, let you set the datasource resource-ref name :
# my application.conf db=java:comp/env/jdbc/myapp db.resourceRef=jdbc/myapp jpa.dialect=org.hibernate.dialect.Oracle9Dialect 3) In utils.py around line 137 I added a search and truncate on multiple lines
4) the RESOURCE_REF_NAME propert in the template web.xml is set to db.resourceRef if it's defined. Otherwise, I just strip out the lines from the web.xml template.

I will also write a short documentation on "how to use a datasource when an application is bundled as a WAR" cause I think it's a real usecase.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

People watching this ticket