#846 ✓wontfix
Zheng Can

TemplateLoader should allow plugins to customize the behavior of seek a template file

Reported by Zheng Can | May 18th, 2011 @ 08:49 AM | in 1.3 (closed)

I developed a ThemePlugin to support multiply theme for Play framework.

When controller try to render a view, the controller use play.templates.TemplateLoader to find and load the template file, then throw a new instance of play.mvc.results.RenderTemplate to render it.

The TemplateLoader seek the template according the path in Play.templatesPath, and return the VirtualFile when the template file is existed.
After that, it will try to load the template with plugin. If failed, it will use default engine to load it.

My ThemePlugin is invoked by TemplateLoader to load the template.
But there are a BIG limitation here.

In TemplateLoader design, the plugin could load the specified template only, and could not do "seek the template" instead the origin behavior. This constraint is suit for template engine plugin, not for any kinds of theme plugin.

I hope TemplateLoader could allow plugins to seek and load template separately.


My ThemePlugin is designed to load templates in thus folder:

/app
    /themes
        /theme_name_1
            /Application
                /index.html
        /theme_name_2
            /Application
                /index.html

BTW: the folder structure of /app/themes/theme_name is same as /app/views

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

People watching this ticket

Referenced by

Pages