#891 ✓worksforme
jeanbaptiste.claramonte (at gmail)

issue on the Blob type : writing "null|null" in the database

Reported by jeanbaptiste.claramonte (at gmail) | June 6th, 2011 @ 09:15 AM

I'am using framework version 1.1.1 but I think the issue should be the same for all next versions.

When you save for the first time an entity with a Blob attribute and
that the Blob attribute is not set it saves a NULL in database : this
is ok.

But the next time it will save the following String in database : null|
null

I don't think this should happen because when you take a look at the
following methods in Blob class :

public void nullSafeSet(PreparedStatement ps, Object o, int i) throws HibernateException, SQLException {
    if(o != null) {
        ps.setString(i, ((Blob)o).UUID + "|" + ((Blob)o).type);
    } else {
        ps.setNull(i, Types.VARCHAR);
    }
}

it writes NULL in bd if o == null
the problem it that o will never be null because nullSafeGet(...)
always create a new Blob instance :

public Object nullSafeGet(ResultSet rs, String[] names, Object o) throws HibernateException, SQLException {
    String val = (String) Hibernate.STRING.nullSafeGet(rs, names[0]);
    if(val == null || val.length() == 0 || !val.contains("|")) {
        return new Blob();
    }
    return new Blob(val.split("[|]")[0], val.split("[|]")[1]);
}

Finally this is creating an unwanted side effect in our application :
it creates a null file in attachments

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Referenced by

Pages