#907 ✓resolved
Mark Hibberd

Performance problems with JPA cascade of OneToMany relationship.

Reported by Mark Hibberd | June 13th, 2011 @ 09:52 AM | in 1.2.4 (closed)

Framework version: Play 1.1.

Reproduction steps:

  • @OneToMany model relationship with cascade = ALL on a list element.
  • Add more then a 1000 items to the list.
  • Save the model object.

Details:

  • The code in JPABase has an O(n^2) lookup to detect loops in the cascading save. Performance degrades rapidly as more items added to the relationship.
  • In an application I am supporting, a save with approximately 2000 items takes 90 seconds. Profiling this, the majority is spent in the avoidCascadeSaveLoops check.
  • I have submitted a pull request #255 that addresses this issue by changing the data-structure used from an ArrayList to a HashSet.
  • Applying this patch results in a significant speed-up for the application mentioned above. The save of 2000 items drops from 90 seconds to less then 2 seconds.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

Referenced by

Pages