#927 new
Daniel Lichtenberger

Connection not closed when sending an InputStream of unknown length

Reported by Daniel Lichtenberger | June 21st, 2011 @ 12:40 PM

Framework version: 1.2.1
Platform you're using: Linux x64, Java 1.6.0_26

Reproduction steps:
I'm sending a (piped) input stream to stream binary contents of unknown length via response.direct = ... as described in this discussion. I was unable to find another way of doing this since the response.writeChunk method does not work for binary content. Everything works when I download the URL via wget, but when I download it in a browser it hangs.

The issue seems to be that Play does not close the connection when a keep-alive request was sent by the browser, but AFAIK this is the only way to tell the client that the download is complete. Using the attached patch the browser no longer hangs. It's just a quick hack, I guess the 'right' way would be to close the connection only if no content length was set.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2>Play framework</h2>

Play makes it easier to build Web applications with Java. It is a clean alternative to bloated Enterprise Java stacks. It focuses on developer productivity and targets RESTful architectures. Learn more on the <a href="http://www.playframework.org">http://www.playframework.org</a> website.<br><br>

<h2>Source code is hosted on github</h2>Check out our repository at <a href="http://github.com/playframework/play">http://github.com/playframework/play</a><br><br>

<h2>Contributing, creating a patch</h2> Please read the <a href="http://play.lighthouseapp.com/projects/57987/contributor-guide">contributor guide</a><br><br>

<h2>Reporting Security Vulnerabilities</h2> Since all bug reports are public, please report any security vulnerability directly to <em>guillaume dot bort at gmail dot com</em>.<br><br>

<h2>Creating a bug report</h2> Bug reports are incredibly helpful, so take time to report bugs and request features in our ticket tracker. We’re always grateful for patches to Play’s code. Indeed, bug reports with attached patches will get fixed far quickly than those without any.<br><br>

Please include as much relevant information as possible including the exact framework version you're using and a code snippet that reproduces the problem.<br><br>

Don't have too much expectations. Unless the bug is really a serious "everything is broken" thing, you're creating a ticket to start a discussion. Having a patch (or a branch on Github we can pull from) is better, but then again we'll only pull high quality branches that make sense to be in the core of Play.

People watching this ticket